Skip to content

Add hardwareId support #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2023
Merged

Add hardwareId support #60

merged 5 commits into from
Feb 9, 2023

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 7, 2023

See arduino/arduino-cli#2024 for more info.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 8, 2023
per1234
per1234 requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: Resolved by 83aaf30

This outdated statement in the readme should be updated to accompany the bump to using Go 1.19 for development and maintenance of the project:

serial-discovery/README.md

Line 7 in fa69a61

Install a recent go environment (>=13.0) and run `go build`. The executable `serial-discovery` will be produced in your working directory.

umbynos
umbynos reviewed Feb 8, 2023
View reviewed changes
@cmaglie
Copy link
Member Author

cmaglie commented Feb 9, 2023

This outdated statement in the readme should be updated to accompany the bump to using Go 1.19

I've just removed the reference to the go version since it's now enforced by go.mod.

@cmaglie cmaglie merged commit 9b71b43 into main Feb 9, 2023
@cmaglie cmaglie deleted the add_hw_id branch February 9, 2023 15:30
@cmaglie cmaglie self-assigned this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 requested changes

@Bikappa Bikappa Awaiting requested review from Bikappa

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

+1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmaglie cmaglie

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmaglie @per1234 @umbynos