Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/pluggable-discovery-protocol-handler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c563e77
Choose a base ref
...
head repository: arduino/pluggable-discovery-protocol-handler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fbec7bc
Choose a head ref
  • 9 commits
  • 10 files changed
  • 3 contributors

Commits on Feb 13, 2024

  1. Bump arduino/setup-task from 1 to 2

    Bumps [arduino/setup-task](https://github.com/arduino/setup-task) from 1 to 2.
    - [Release notes](https://github.com/arduino/setup-task/releases)
    - [Commits](arduino/setup-task@v1...v2)
    
    ---
    updated-dependencies:
    - dependency-name: arduino/setup-task
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    af3c151 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #47 from arduino/dependabot/github_actions/arduino…

    …/setup-task-2
    
    Bump arduino/setup-task from 1 to 2
    per1234 authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    24fefb0 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configure actions/upload-artifact action to upload required hidden files

    A breaking change was made in the 3.2.1 release of the "actions/upload-artifact" action, without doing a major version
    bump as would be done in a responsibly maintained project. The action now defaults to not uploading "hidden" files.
    
    This project's "Check Go Dependencies" workflow uses the "Licensed" tool to check for incompatible dependency licenses.
    The dependencies license metadata cache used by Licensed is stored in a folder named `.licensed`.
    
    In order to facilitate updates, the workflow uploads the generated dependencies license metadata cache as a workflow
    artifact when the current cache is found to be outdated.
    
    The `.` at the start of the `.licensed` folder name causes it to now not be uploaded to the workflow artifact. In order
    to catch such problems, the workflow configures the "actions/upload-artifact" action to fail if no files were uploaded.
    So in addition to not uploading the artifact, the change in the "actions/upload-artifact" action's behavior also
    resulted in the workflow runs failing:
    
    Error: No files were found with the provided path: .licenses/. No artifacts will be uploaded.
    
    The problem is fixed by disabling the "actions/upload-artifact" action's new behavior via the `include-hidden-files`
    input. After this change, the workflow can once more upload the dependencies license metadata cache to a workflow
    artifact as needed.
    per1234 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dfad58b View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge pull request #49 from per1234/include-hidden-files

    Configure actions/upload-artifact action to upload required hidden files
    per1234 authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6ae82f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Removed useless mutex locks

    cmaglie committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    36c5780 View commit details
    Browse the repository at this point in the history
  2. Added unit tests

    cmaglie committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f305b10 View commit details
    Browse the repository at this point in the history
  3. Always report errors before closing the channel

    Otherwise the call to:
    
       msg, err := disc.waitMessage(..)
    
    may return both msg and err as nil, breaking the contract.
    cmaglie committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0369df2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc38790 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge pull request #50 from arduino/fix_crashing_disc_handling

    Fix panic when dealing with crashing discoveries
    cmaglie authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fbec7bc View commit details
    Browse the repository at this point in the history
Loading