Skip to content

Conversation

@ilcato
Copy link
Contributor

@ilcato ilcato commented Feb 18, 2021

Replaced async-request package with SuperAgent package that doesn't contains dependencies on deprecated modules or security issues.

@umbynos umbynos self-requested a review February 19, 2021 18:11
@umbynos
Copy link
Contributor

umbynos commented Feb 19, 2021

Just installed, should be working fine:

bash-5.0$ npm install node-red-contrib-arduino-iot-cloud/
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/@arduino/node-red-contrib-arduino-iot-cloud/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN @babel/cli@7.7.4 requires a peer of @babel/core@^7.0.0-0 but none is installed. You must install peer dependencies yourself.

+ @arduino/node-red-contrib-arduino-iot-cloud@1.0.5
added 4 packages from 8 contributors in 3.313s

1 package is looking for funding
  run `npm fund` for details

image

Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏁

@umbynos umbynos merged commit 99c63f0 into arduino:master Feb 22, 2021
@ilcato ilcato deleted the fix-npm-secure-warning branch August 11, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants