Remove github.com/VasilKalchev/RGBLED from libraries list #6561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that a compliant release of this library was never created, meaning that although there is a registry entry, the library is not actually listed in the libraries index. The registration occurred eight years ago and the repository has since either been deleted or made private, so a release of the library will never come. Thus, removing the registration will not cause any harm. The existence of this "ghost registration" is problematic because the duplicate name check system uses the libraries index. Since the library is not present there, the check doesn't see that the name "RGBLED" has already been registered and thus will allow registration of additional libraries with that name. In addition, its presence may cause confusion to the registry maintainers since we expect each registration to have a unique name. Since the registration of the library provides no benefit and causes harm, it is removed.
Contributor
|
Hi @per1234. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that a compliant release of this library was never created, meaning that although there is a registry entry, the library is not actually listed in the libraries index.
The registration occurred eight years ago (arduino/Arduino#6257) and the repository has since either been deleted or made private, so a release of the library will never come. Thus, removing the registration will not cause any harm.
The existence of this "ghost registration" is problematic because the duplicate name check system uses the libraries index. Since the library is not present there, the check doesn't see that the name "RGBLED" has already been registered and thus will allow registration of additional libraries with that name (e.g., #6509). In addition, its presence may cause confusion to the registry maintainers since we expect each registration to have a unique name.
Since the registration of the library provides no benefit and causes harm, it is removed.