Skip to content

Conversation

@goodisplayshare
Copy link
Contributor

@github-actions github-actions bot added the topic: submission Add library to the list label Oct 25, 2024
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/goodisplayshare/esp32-epd

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 mentioned this pull request Oct 25, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @goodisplayshare. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/goodisplayshare/esp32-epd/tree/v1.0.1

(note that the repository doesn't contain a library.properties file at that point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Oct 25, 2024
@per1234 per1234 mentioned this pull request Oct 25, 2024
@goodisplayshare
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/goodisplayshare/esp32-epd

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Oct 25, 2024
@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@goodisplayshare
Copy link
Contributor Author

A problem was found with your submission https://github.com/goodisplayshare/esp32-epd

❌ ERROR: Library is missing a library.properties metadata file.

How should I handle this matter? There is this file in the library?

@goodisplayshare
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/goodisplayshare/esp32-epd

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@goodisplayshare
Copy link
Contributor Author

❌ ERROR: Library is missing a library.properties metadata file.
I obviously have this file in my library, what should I do? ?

@goodisplayshare
Copy link
Contributor Author

❌ ERROR: Library is missing a library.properties metadata file.
I obviously have this file in my library, what should I do? ? @per1234

@goodisplayshare
Copy link
Contributor Author

goodisplayshare commented Oct 25, 2024 via email

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/goodisplayshare/esp32-epd

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@goodisplayshare
Copy link
Contributor Author

@per1234, can you tell me what to do next?

@per1234 per1234 mentioned this pull request Oct 25, 2024
@per1234
Copy link
Contributor

per1234 commented Oct 25, 2024

@goodisplayshare I already explained what you need to do. Please read it again very very carefully:

#5289 (review)

Note that the explanation includes links you can follow to get even more information.

If there is something you don't understand, comment here with a detailed explanation of what exactly you don't understand and I will provide further assistance. DO NOT CREATE MORE PULL REQUESTS!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

My English is not very good

I use Google Translate every day and find it does an excellent job.

@goodisplayshare
Copy link
Contributor Author

@per1234 ,Is it because I added the library. properties metadata file, or is there an error? What other possible reasons could it be

@per1234
Copy link
Contributor

per1234 commented Oct 25, 2024

Please use Google Translate to translate the text of my comment at #5289 (review) to your native language, then read it very carefully. I have explained the cause of the problem and how you can fix it there.

If there is something specific you don't understand about what I wrote, you can provide a detailed description of exactly which part of what I wrote you don't understand, and what you don't understand about it. Or if you understood what I wrote, but encountered a problem while trying to follow the instructions I provided, you can provide a detailed description of what you tried and what problem you encountered.

@goodisplayshare
Copy link
Contributor Author

”I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository." At present, it is still in an error state and the error issue has not been resolved. It still prompts for missing files @per1234

@goodisplayshare
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/goodisplayshare/esp32-epd

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@goodisplayshare
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd:

Linting library in esp32-epd
INFO: No header file found matching library name (AceRoutine.h). Best practices are for primary header filename to match
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name AceRoutine is in use by a library in the Library Manager index. Each library must have a unique name
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@goodisplayshare
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd:

Linting library in esp32-epd
INFO: No header file found matching library name (AceRoutine.h). Best practices are for primary header filename to match
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name AceRoutine is in use by a library in the Library Manager index. Each library must have a unique name
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@goodisplayshare
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/goodisplayshare/esp32-epd:

Linting library in esp32-epd
INFO: No header file found matching library name (esp32-epd.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties depends field item(s) esp32-epd not found in the Library Manager index.            
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP048)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 October 26, 2024 23:55
@goodisplayshare
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 October 27, 2024 00:19
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd:

Linting library in esp32-epd
INFO: No header file found matching library name (esp32-epd_Library.h). Best practices are for primary header filename  
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value esp32-epd Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP010)                                                                                           
WARNING: library.properties name esp32-epd Library contains spaces. Although supported, best practices is to not use    
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name esp32-epd Library contains "library". This is superfluous.                               
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
ERROR: Invalid format of library.properties depends field *                                                  
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP047)                                                                                          
WARNING: library.properties depends field item(s) * not found in the Library Manager index.                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP048)                                                                                          
WARNING: library.properties includes field item(s) esp32-epd.h not found in library.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 6 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd:

Linting library in esp32-epd
INFO: No header file found matching library name (esp32-epd_Library.h). Best practices are for primary header filename  
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value esp32-epd Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP010)                                                                                           
WARNING: library.properties name esp32-epd Library contains spaces. Although supported, best practices is to not use    
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name esp32-epd Library contains "library". This is superfluous.                               
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
ERROR: Invalid format of library.properties depends field *                                                  
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP047)                                                                                          
WARNING: library.properties depends field item(s) * not found in the Library Manager index.                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP048)                                                                                          
WARNING: library.properties includes field item(s) esp32-epd.h not found in library.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 6 WARNINGS

-------------------

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Oct 27, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in adding your library to the Arduino Library Manager @goodisplayshare. We have reviewed your library and determined that it does not meet the quality standards for inclusion in Library Manager.

This decision is final so please don't attempt to submit the library again.

@per1234 per1234 closed this Oct 27, 2024
@per1234 per1234 added the conclusion: declined Will not be worked on label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: declined Will not be worked on topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants