-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update repositories.txt #5289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repositories.txt #5289
Conversation
|
A problem was found with your submission https://github.com/goodisplayshare/esp32-epd ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @goodisplayshare. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/goodisplayshare/esp32-epd/tree/v1.0.1
(note that the repository doesn't contain a library.properties file at that point in the revision history)
❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
|
Hello! I'm checking your submission again. |
|
A problem was found with your submission https://github.com/goodisplayshare/esp32-epd ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
A problem was found with your submission https://github.com/goodisplayshare/esp32-epd ❌ ERROR: Library is missing a library.properties metadata file. How should I handle this matter? There is this file in the library? |
|
Hello! I'm checking your submission again. |
|
A problem was found with your submission https://github.com/goodisplayshare/esp32-epd ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
❌ ERROR: Library is missing a library.properties metadata file. |
|
❌ ERROR: Library is missing a library.properties metadata file. |
|
Hello, I have installed and added the library.properties file to the github library, but I still get an error.
Can you help me?
My English is not very good and I didn't check my previous comments in time. I'm very sorry.
Thank you ~
At 2024-10-25 14:40:07, "per1234" ***@***.***> wrote:
@per1234 commented on this pull request.
Hello @goodisplayshare. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/goodisplayshare/esp32-epd/tree/v1.0.1
(note that the repository doesn't contain a library.properties file at that point in the revision history)
❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hello! I'm checking your submission again. |
|
A problem was found with your submission https://github.com/goodisplayshare/esp32-epd ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
@per1234, can you tell me what to do next? |
|
@goodisplayshare I already explained what you need to do. Please read it again very very carefully: Note that the explanation includes links you can follow to get even more information. If there is something you don't understand, comment here with a detailed explanation of what exactly you don't understand and I will provide further assistance. DO NOT CREATE MORE PULL REQUESTS!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
I use Google Translate every day and find it does an excellent job. |
|
@per1234 ,Is it because I added the library. properties metadata file, or is there an error? What other possible reasons could it be |
|
Please use Google Translate to translate the text of my comment at #5289 (review) to your native language, then read it very carefully. I have explained the cause of the problem and how you can fix it there. If there is something specific you don't understand about what I wrote, you can provide a detailed description of exactly which part of what I wrote you don't understand, and what you don't understand about it. Or if you understood what I wrote, but encountered a problem while trying to follow the instructions I provided, you can provide a detailed description of what you tried and what problem you encountered. |
|
”I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository." At present, it is still in an error state and the error issue has not been resolved. It still prompts for missing files @per1234 |
|
Hello! I'm checking your submission again. |
|
A problem was found with your submission https://github.com/goodisplayshare/esp32-epd ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
Hello! I'm checking your submission again. |
|
❌ ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
Hello! I'm checking your submission again. |
|
❌ ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
Hello! I'm checking your submission again. |
|
Arduino Lint has suggestions for possible improvements to https://github.com/goodisplayshare/esp32-epd: |
|
❌ ERROR: Your submission meets all requirements. However, the pull request could not be merged. Please follow this guide to resolve a merge conflict: Once that is done, it will be merged automatically. |
|
Hello! I'm checking your submission again. |
|
❌ ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
❌ ERROR: Arduino Lint found errors with https://github.com/goodisplayshare/esp32-epd: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @goodisplayshare After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your interest in adding your library to the Arduino Library Manager @goodisplayshare. We have reviewed your library and determined that it does not meet the quality standards for inclusion in Library Manager.
This decision is final so please don't attempt to submit the library again.
@ArduinoBot