Skip to content

Update repositories.txt #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2023
Merged

Update repositories.txt #3152

merged 2 commits into from
Aug 2, 2023

Conversation

@Dhruvacube
Copy link
Contributor

@Dhruvacube Dhruvacube commented Aug 1, 2023 •
edited
Loading

A new 7 seg library

@github-actions github-actions bot added the topic: submission Add library to the list label Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

❌ ERROR: Arduino Lint found errors with https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment_Library.h). Best practices are for primary header       
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Led 7 Segment Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP010)                                                                                               
WARNING: library.properties name Led 7 Segment Library contains spaces. Although supported, best practices is to not use
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Led 7 Segment Library contains "library". This is superfluous.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Custom Character
ERROR: Prohibited character(s) in file name(s): Custom Character.ino                                   
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Dhruvacube
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 1, 2023

ok lemme correct it real quicl

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 1, 2023

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

❌ ERROR: Arduino Lint found errors with https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment_Library.h). Best practices are for primary header       
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Led 7 Segment Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP010)                                                                                               
WARNING: library.properties name Led 7 Segment Library contains spaces. Although supported, best practices is to not use
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Led 7 Segment Library contains "library". This is superfluous.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Custom Character
ERROR: Prohibited character(s) in file name(s): Custom Character.ino                                   
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Dhruvacube
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 1, 2023

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

❌ ERROR: Arduino Lint found errors with https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment_Library.h). Best practices are for primary header       
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Led 7 Segment Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP010)                                                                                               
WARNING: library.properties name Led 7 Segment Library contains spaces. Although supported, best practices is to not use
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Led 7 Segment Library contains "library". This is superfluous.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Custom Character
ERROR: Prohibited character(s) in file name(s): Custom Character.ino                                   
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Dhruvacube
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 1, 2023

ahhhh linking of tags

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 1, 2023

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

❌ ERROR: Arduino Lint found errors with https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment_Library.h). Best practices are for primary header       
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Led 7 Segment Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP010)                                                                                               
WARNING: library.properties name Led 7 Segment Library contains spaces. Although supported, best practices is to not use
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Led 7 Segment Library contains "library". This is superfluous.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Custom Character
ERROR: Prohibited character(s) in file name(s): Custom Character.ino                                   
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Dhruvacube
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 1, 2023

hmmmmm i will come and check tommrow

@per1234 per1234 self-assigned this Aug 1, 2023
per1234
per1234 reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Dhruvacube. I see you have fixed the error reported by the bot:

#3152 (comment)

ERROR: Prohibited character(s) in file name(s): Custom Character.ino                                   
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)

However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/Dhruvacube/7-Segment/tree/v0.0.1/examples/Custom%20Character

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Aug 2, 2023
@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 2, 2023

Hello @Dhruvacube. I see you have fixed the error reported by the bot:

#3152 (comment)

ERROR: Prohibited character(s) in file name(s): Custom Character.ino                                   
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)

However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/Dhruvacube/7-Segment/tree/v0.0.1/examples/Custom%20Character

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

oh ok got, then lemme quickly make nice readme file publish the new changes into a new version

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Hello! I'm checking your submission again.

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 2, 2023

Hello! I'm checking your submission again.

eehhhh not now , bruh

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

❌ ERROR: Arduino Lint found errors with https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment_Library.h). Best practices are for primary header       
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Led 7 Segment Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP010)                                                                                               
WARNING: library.properties name Led 7 Segment Library contains spaces. Although supported, best practices is to not use
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Led 7 Segment Library contains "library". This is superfluous.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Custom Character
ERROR: Prohibited character(s) in file name(s): Custom Character.ino                                   
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Dhruvacube
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 2, 2023

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

❌ ERROR: Arduino Lint found errors with https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Led 7 Segment contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/CustomCharacter

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Dhruvacube
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 2, 2023

Ahhhh now praragraph field is required

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

❌ ERROR: Arduino Lint found errors with https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Led 7 Segment contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/CustomCharacter

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Dhruvacube
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Aug 2, 2023
@Dhruvacube
Copy link
Contributor Author

Dhruvacube commented Aug 2, 2023

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Arduino Lint has suggestions for possible improvements to https://github.com/Dhruvacube/7-Segment:

Linting library in 7-Segment
INFO: No header file found matching library name (Led_7_Segment.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Led 7 Segment contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in 7-Segment/examples/All

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Alphabets

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/CustomCharacter

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Number

Linter results for project: no errors or warnings

-------------------

Linting sketch in 7-Segment/examples/Range

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit 92afecc into arduino:main Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Dhruvacube/7-Segment/

github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
@ArduinoBot
Add submission # 3152
ea345bb 
#3152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@per1234 per1234

Labels

topic: submission Add library to the list

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dhruvacube @per1234