Use less ambiguous name for workflow job handling non-submission PRs #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event a PR is detected as something other than a library submission, a review is requested from the Tooling Team and a comment is made to the PR thread explaining the situation. Previously, this job was named `request-review`. However, there are other circumstances under which a review will be requested (e.g., merge conflict). So this was not a very good job name. This job name is not referenced anywhere else in the workflow, so it currently only serves a documentation role and changing it has no functional effect.
Contributor
|
Hi @per1234. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
per1234
added
topic: documentation
silvanocerza
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event a PR is detected as something other than a library submission, a review is requested from the Tooling Team and a comment is made to the PR thread explaining the situation.
Previously, the job handling this was named
request-review. However, there are other circumstances under which a review will be requested (e.g., merge conflict). So this was not a very good job name.This job name is not referenced anywhere else in the workflow, so it currently only serves a documentation role and changing it has no functional effect.