Skip to content

Conversation

@per1234
Copy link
Contributor

@per1234 per1234 commented Apr 26, 2021

When there is a problem with the submission that must be resolved in the library repository, a comment mentioning
@ArduinoBot is used to trigger the "Manage PRs" workflow.

We are accustomed to seeing the checks status in the PR thread when workflows are running. However, with a comment
triggered workflow this does not happen. The only indication of the workflow running is on the "Actions" tab. This can
leave the submitter wondering if their comment had any effect as the workflow takes some time to run before providing
feedback.

This uncertainty can be avoided by making the bot immediately comment to acknowledge that the check is in progress.

Demo: per1234#21 (comment)

When there is a problem with the submission that must be resolved in the library repository, a comment mentioning
`@ArduinoBot` is used to trigger the "Manage PRs" workflow.

We are accustomed to seeing the checks status in the PR thread when workflows are running. However, with a comment
triggered workflow this does not happen. The only indication of the workflow running is on the "Actions" tab. This can
leave the submitter wondering if their comment had any effect as the workflow takes some time to run before providing
feedback.

This uncertainty can be avoided by making the bot immediately comment to acknowledge that the check is in progress.
@github-actions
Copy link
Contributor

Hi @per1234.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the other label Apr 26, 2021
@per1234 per1234 merged commit 23c5904 into main Apr 26, 2021
@per1234 per1234 deleted the comment-on-comment-trigger branch April 26, 2021 08:37
@rsora rsora added the topic: other Something other than a library list request label Sep 22, 2021
@per1234 per1234 removed the other label Oct 20, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: other Something other than a library list request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants