Use previous tag as base when "Compare Performance" workflow triggered by tag #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by tag The engine has three trigger events, each with their own base ref: - push: parent commit - pull request: PR base ref - manual trigger: arbitrary ref selected by the user The `push` event is triggered by both commit pushes and tag pushes. It turns out the github context field that provides the parent commit ref is set to `0000000000000000000000000000000000000000` on a tag push, which caused the workflow to fail. Although it would be possible to get the parent commit ref via a git command, this isn't a useful comparison to get from a tag push. The more useful comparison will be against the previous tag.
Under some unexpected circumstances, the information used to determine the ref for the base of the comparison might be missing, which would result in an empty definition for the ref. Since the `actions/checkout` action defaults to checking out the tip of the default branch, this would not be reported and would result in spurious results. Better will be to cause the relevant workflow step to fail with a helpful error message.
silvanocerza
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine has three trigger events, each with their own base ref:
The
pushevent is triggered by both commit pushes and tag pushes. It turns out the github context field that providesthe parent commit ref is set to
0000000000000000000000000000000000000000on a tag push, which caused the workflow tofail. Although it would be possible to get the parent commit ref via a git command, this isn't a useful comparison to get
from a tag push. The more useful comparison will be against the previous tag.
Previous version of the workflow failing on a tag push:
https://github.com/arduino/libraries-repository-engine/actions/runs/1194197512
Demo of this version triggered by a tag push:
https://github.com/per1234/libraries-repository-engine/actions/runs/1198521674