Skip to content

Conversation

@seaxwi
Copy link
Collaborator

@seaxwi seaxwi commented Mar 28, 2022

Changes proposed in this pull request
Various improvements to content and structure.

@seaxwi seaxwi requested a review from Renat0Ribeir0 March 28, 2022 13:57
Copy link
Contributor

@Renat0Ribeir0 Renat0Ribeir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good structure! 👍 Made one comment on the checklist. You're probably aware of it, but there are some parts commented out that need to be implemented.

@seaxwi
Copy link
Collaborator Author

seaxwi commented Apr 4, 2022

@Renat0Ribeir0

  • Cleaned up comments
    • avrdude: ser_open(): can't open device "portName": the system cannot find the file specified will be covered in HC-963
    • Moving test cases to different documentation
  • Trimmed the general checklist, and ephesised the error-specific steps in the introduction. More in-depth general troubleshooting is better for Errors when uploading a sketch which will be updated in HC-949

@seaxwi seaxwi requested a review from Renat0Ribeir0 April 4, 2022 12:16
Copy link
Contributor

@Renat0Ribeir0 Renat0Ribeir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo to correct, otherwise LGTM 👍

…ding.md

Co-authored-by: Renat0Ribeir0 <86349945+Renat0Ribeir0@users.noreply.github.com>
@seaxwi seaxwi merged commit 73e06ca into main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants