Skip to content

New content for Giga R1 Wifi and updates to some Portenta H7 content. #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 7, 2023
Merged

New content for Giga R1 Wifi and updates to some Portenta H7 content. #181

merged 12 commits into from
Mar 7, 2023

Conversation

@seaxwi
Copy link
Collaborator

@seaxwi seaxwi commented Mar 6, 2023

Internal keys: HC-1201, HC-1175, HC-1174, HC-1200

Renat0Ribeir0
Renat0Ribeir0 suggested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@Renat0Ribeir0 Renat0Ribeir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good articles and great pictures! Added some suggestions to improve readability and consistency.

@seaxwi @Renat0Ribeir0
Apply suggestions from code review
093ff41 
Co-authored-by: Renat0Ribeir0 <86349945+Renat0Ribeir0@users.noreply.github.com>
KongTruss
KongTruss reviewed Mar 7, 2023
View reviewed changes
Copy link

@KongTruss KongTruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great. Just wondering if were you able to upload the FW without needing to upload the QSPI format sketch? Otherwise, everything is good on my side, great job!

@seaxwi
Copy link
Collaborator Author

seaxwi commented Mar 7, 2023

All looks great. Just wondering if were you able to upload the FW without needing to upload the QSPI format sketch? Otherwise, everything is good on my side, great job!

As I understand it, that shouldn't be necessary with production boards.

But please let me know if you get any reports to the contrary.

@seaxwi seaxwi requested a review from Renat0Ribeir0 March 7, 2023 11:56
@seaxwi
Copy link
Collaborator Author

seaxwi commented Mar 7, 2023

@Renat0Ribeir0 I reworked content/Hardware Support/Portenta Family/Update-Wi-Fi-firmware-on-Portenta-H7-boards.md, can you have a look?

Renat0Ribeir0
Renat0Ribeir0 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@Renat0Ribeir0 Renat0Ribeir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion. LGTM otherwise 👍

@seaxwi seaxwi merged commit 4f74999 into main Mar 7, 2023
@seaxwi seaxwi deleted the giga-r1-wifi branch March 7, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KongTruss KongTruss KongTruss approved these changes

+2 more reviewers

@jojo1212 jojo1212 jojo1212 approved these changes

@Renat0Ribeir0 Renat0Ribeir0 Renat0Ribeir0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seaxwi @jojo1212 @KongTruss @Renat0Ribeir0