Skip to content

Portenta X8: Foundries.io review #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 10, 2022
Merged

Conversation

vanmaegima
Copy link
Contributor

What This PR Changes

  • First content review from Foundries.io

Contribution Guidelines

List the required files as they are shown in the factory and manifest release
pages.

Add a note on which files should be extracted before continuing the tutorial.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Use 'booting' instead of 'flashing' as at the moment we are past
the flashing stage.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
The mentioned page won't be available at the time we boot the board,
so mention that it can take up to 15 seconds to show up after boot.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
'portenta-X8 board manager' should be 'Portenta X8 Board Manager' as shown
in the Arduino Cloud page.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
To achieve the steps shown and de-register a board, first we need to
stop aktualizr-lite and fioconfig services.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
We don't perform automatic factory registration for the Arduino
factories so remove this information.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Sync Sources description with Foundries.io documentation in
https://docs.foundries.io/latest/reference-manual/factory/factory-sources.html

Include detailed information on how to trigger builds and create
new targets.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Installing fioctl links to an old release, so update this to avoid getting
an old version of fioctl.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Previous command using repo didn't work to clone the repository
so use git instead.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
… times

Building and updating takes time, so make this clear in the documentation.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
@CLAassistant
Copy link

CLAassistant commented Aug 8, 2022

CLA assistant check
All committers have signed the CLA.

@marqdevx marqdevx changed the title Foundries.io review Portenta X8: Foundries.io review Aug 8, 2022
@marqdevx marqdevx added fix/update A small fix or update Tutorial pro labels Aug 8, 2022
@marqdevx marqdevx requested review from marqdevx and BenjaminDannegard and removed request for marqdevx August 8, 2022 19:45
Copy link
Member

@marqdevx marqdevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BenjaminDannegard BenjaminDannegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenjaminDannegard BenjaminDannegard merged commit e292417 into arduino:main Aug 10, 2022
Serjlee pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix/update A small fix or update pro Tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants