-
-
Notifications
You must be signed in to change notification settings - Fork 439
Portenta X8: Foundries.io review #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List the required files as they are shown in the factory and manifest release pages. Add a note on which files should be extracted before continuing the tutorial. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Use 'booting' instead of 'flashing' as at the moment we are past the flashing stage. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
The mentioned page won't be available at the time we boot the board, so mention that it can take up to 15 seconds to show up after boot. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
'portenta-X8 board manager' should be 'Portenta X8 Board Manager' as shown in the Arduino Cloud page. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
To achieve the steps shown and de-register a board, first we need to stop aktualizr-lite and fioconfig services. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
We don't perform automatic factory registration for the Arduino factories so remove this information. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Sync Sources description with Foundries.io documentation in https://docs.foundries.io/latest/reference-manual/factory/factory-sources.html Include detailed information on how to trigger builds and create new targets. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Installing fioctl links to an old release, so update this to avoid getting an old version of fioctl. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Previous command using repo didn't work to clone the repository so use git instead. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
… times Building and updating takes time, so make this clear in the documentation. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
marqdevx
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BenjaminDannegard
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines