Skip to content

Handle "N/A" warning count data when generating summary report #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Handle "N/A" warning count data when generating summary report #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions compilesketches/compilesketches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,14 +1356,22 @@ def get_warnings_summary_report(self, sketch_report_list):
if (
summary_report_minimum is None
or summary_report_minimum == self.not_applicable_indicator
or summary_report_minimum > sketch_report_delta
):
summary_report_minimum = sketch_report_delta
elif (
sketch_report_delta != self.not_applicable_indicator
and summary_report_minimum > sketch_report_delta
):
summary_report_minimum = sketch_report_delta

if (
summary_report_maximum is None
or summary_report_maximum == self.not_applicable_indicator
or summary_report_maximum < sketch_report_delta
):
summary_report_maximum = sketch_report_delta
elif (
sketch_report_delta != self.not_applicable_indicator
and summary_report_maximum < sketch_report_delta
):
summary_report_maximum = sketch_report_delta

Expand Down
121 changes: 121 additions & 0 deletions compilesketches/tests/test_compilesketches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,6 +2386,127 @@ def test_get_warnings_summary_report():
expected_warnings_summary_report
)

sketch_report_list = [
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: 3
}
},
},
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: 42
}
}
}
]

expected_warnings_summary_report = {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: {
compilesketches.CompileSketches.ReportKeys.minimum: 3,
compilesketches.CompileSketches.ReportKeys.maximum: 42
}
}
}

assert compile_sketches.get_warnings_summary_report(sketch_report_list=sketch_report_list) == (
expected_warnings_summary_report
)

# N/As
sketch_report_list = [
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: compile_sketches.not_applicable_indicator
}
},
},
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: 3
}
}
}
]

expected_warnings_summary_report = {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: {
compilesketches.CompileSketches.ReportKeys.minimum: 3,
compilesketches.CompileSketches.ReportKeys.maximum: 3
}
}
}

assert compile_sketches.get_warnings_summary_report(sketch_report_list=sketch_report_list) == (
expected_warnings_summary_report
)

sketch_report_list = [
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: 42
}
},
},
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: compile_sketches.not_applicable_indicator
}
}
}
]

expected_warnings_summary_report = {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: {
compilesketches.CompileSketches.ReportKeys.minimum: 42,
compilesketches.CompileSketches.ReportKeys.maximum: 42
}
}
}

assert compile_sketches.get_warnings_summary_report(sketch_report_list=sketch_report_list) == (
expected_warnings_summary_report
)

sketch_report_list = [
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: compile_sketches.not_applicable_indicator
}
},
},
{
compilesketches.CompileSketches.ReportKeys.warnings: {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: compile_sketches.not_applicable_indicator
}
}
}
]

expected_warnings_summary_report = {
compilesketches.CompileSketches.ReportKeys.delta: {
compilesketches.CompileSketches.ReportKeys.absolute: {
compilesketches.CompileSketches.ReportKeys.minimum: compile_sketches.not_applicable_indicator,
compilesketches.CompileSketches.ReportKeys.maximum: compile_sketches.not_applicable_indicator
}
}
}

assert compile_sketches.get_warnings_summary_report(sketch_report_list=sketch_report_list) == (
expected_warnings_summary_report
)

# Test with deltas disabled
sketch_report_list = [
{
Expand Down