Skip to content

Fix plotter issues #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2022
Merged

Fix plotter issues #5

merged 5 commits into from
Jan 13, 2022

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Dec 16, 2021

This PR fixes some minor bug on the serial plotter:

  • maximim number of variables is now correctly computed, avoiding a "blank screen" issue when more than 8 variables were plotted
  • when the plotter toggles between pause and unpaused, "dirty" messages can be received, which cannot be parsed correctly. for this reason is safer to discard such messages and wait for the first clean one
  • when the plotter is disconnected, chart tooltips are now enabled
  • when the plotter is disconnected, a snackbar is shown to make the status more visible

@fstasi fstasi requested a review from AlbyIanna December 16, 2021 16:07
@fstasi fstasi force-pushed the fix-plotter-max-variables branch from cd582ef to 93efec7 Compare December 16, 2021 16:08
@fstasi fstasi force-pushed the fix-plotter-max-variables branch from 3ceeaeb to 0aafb86 Compare December 22, 2021 10:22
This was referenced Jan 12, 2022
Closed
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 12, 2022
@fstasi fstasi merged commit 6e1abbc into main Jan 13, 2022
@nmzaheer nmzaheer mentioned this pull request Sep 7, 2022
Open
3 tasks
@per1234 per1234 deleted the fix-plotter-max-variables branch October 19, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@fstasi fstasi

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fstasi @per1234