Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Conversation

@BenjaminDannegard
Copy link
Collaborator

@BenjaminDannegard BenjaminDannegard commented Mar 31, 2021

For tutorials:

  • I double checked the wiring in the schematics/images
  • I exported the cover image without background
  • I used SVG format for pure vector images
  • I updated the metadata.json file of the tutorial
  • I updated the metadata.json file of the previous tutorial to contain the "next" link
  • I did a spell checking before requesting a review
  • I used title case for titles

@sebromero
Copy link
Collaborator

@BenjaminDannegard Don't forget to add the reviewer and revision:

❌ The authors' format is incorrect. Trailing spaces missing? in content/tutorials/portenta-h7/vs-openmv-ttn/content.md:null
❌ The reviewer's format is incorrect. Review date added YYYY-MM-DD? in content/tutorials/portenta-h7/vs-openmv-ttn/content.md:null
❌ The revisor's format is incorrect. Revision date correct YYYY-MM-DD? in content/tutorials/portenta-h7/vs-openmv-ttn/content.md:null

Copy link
Collaborator

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few notes

@sebromero
Copy link
Collaborator

@BenjaminDannegard Please add the tutorial to the main metadata.json file so that it shows up in the list. Here: https://github.com/arduino/arduino-pro-content/blob/lora-openmv-gs/content/tutorials/portenta-h7/metadata.json

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2021

CLA assistant check
All committers have signed the CLA.

@sebromero sebromero changed the title Lora openmv gs Add getting started with Lora on OpenMV tutorial Apr 26, 2021
BenjaminDannegard and others added 4 commits May 7, 2021 13:11
Co-authored-by: Lenard George Swamy  <lenardgeorge92@gmail.com>
Co-authored-by: Lenard George Swamy  <lenardgeorge92@gmail.com>
Co-authored-by: Lenard George Swamy  <lenardgeorge92@gmail.com>
Copy link
Collaborator

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenjaminDannegard @Lenardgeorge Given that this tutorial will be on the docs website in context of the vision shield, there's no need to add the product to the title. Wdyt?

@Lenardgeorge Lenardgeorge merged commit ef854c5 into main May 7, 2021
@Lenardgeorge Lenardgeorge deleted the lora-openmv-gs branch May 7, 2021 13:44
Lenardgeorge added a commit that referenced this pull request May 11, 2021
* Tutorial for TTN with OpenMV

* Fixed spelling and titles

* Added reviewer and revision

* Update content/tutorials/portenta-h7/vs-openmv-ttn/content.md

Co-authored-by: Sebastian Romero <s.romero@arduino.cc>

* Fixed trailing spaces

* Revert "Fixed trailing spaces"

This reverts commit 8f5f756.

* Fixed trailing spaces

* Changed metadata files

* Added more content to the third section in instructions

* Fixed title, and notes

* Code explanation

* Mention of MicroPython

* Restructured the code and explanation

* Added frontmatter

* Remove unused metadata file

* Update content/tutorials/portenta-h7/vs-openmv-ttn/content.md

Co-authored-by: Lenard George Swamy  <lenardgeorge92@gmail.com>

* Update content/tutorials/portenta-h7/vs-openmv-ttn/content.md

Co-authored-by: Lenard George Swamy  <lenardgeorge92@gmail.com>

* Update content/tutorials/portenta-h7/vs-openmv-ttn/content.md

Co-authored-by: Lenard George Swamy  <lenardgeorge92@gmail.com>

* Changed the titel

* Added final images

* Removed images and fixed titles

* Updated title

Co-authored-by: Sebastian Romero <s.romero@arduino.cc>
Co-authored-by: Lenard George Swamy  <lenardgeorge92@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants