Make --recursive flag a string input #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Dec 11, 2020
Previously, the `--recursive` flag had a Boolean type. That is logical, since it uses values of true and false. However, the fact that the default value of this flag is true changes matters. With the other Boolean flags, the default value is false, so when you want to set it to true you only need to use the flag without a value, as is standard. But with a default true flag it's necessary to unset the value, which can't be done with a bare flag, so you must pass false to the flag. You would expect to be able to do this with either a space separator or an equals sign, just like with the string flags, but the former is not supported: $ ./arduino-check --recursive false Configuration error: PROJECT_PATH argument false does not exist Only the equals sign is supported (`--recursive=false`). So I think the UI is more intuitive with this flag a string type, so the behavior is consistent with the other flags.
per1234
force-pushed
the
per1234/recursive-flag-string
branch
from
b2a56e8 to
c260881
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
--recursiveflag had a Boolean type. That is logical, since it uses values of true and false. However,the fact that the default value of this flag is true changes matters. With the other Boolean flags, the default value
is false, so when you want to set it to true you only need to use the flag without a value, as is standard. But with a
default true flag it's necessary to unset the value, which can't be done with a bare flag, so you must pass false to the
flag. You would expect to be able to do this with either a space separator or an equals sign, just like
with the string flags, but the former is not supported:
Only the equals sign syntax is supported (
--recursive=false).So I think the UI is more intuitive with this flag a string type, so the behavior is consistent with the other flags.