Fix bugs in check functions #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the check level was being used rather than the check result, meaning the failure message wasn't shown when the check failed but the configuration resulted it being a warning.
Previously, the check was failing for any pattern validation failure, causing it to overlap with other checks.
Three identical tests were being run for the permissive compliance level when the intent was to run one for each level.
The regular expression was only intended to check for prohibited characters, but it was inadvertently enforcing a minimum length of 1, which was also inherited by the name property schema (which already has a separate minimum length schema). There is currently no plans to add a minimum length requirement for the depends field, and if that is desired, it is better accomplished via the "minLength" schema.
Although the library specification says "Version should be semver compliant", it also says "1.2 is accepted", so relaxed semver is specification-compliant.
For some reason, this specific sentence results in a non-nil diff of lenght > 0. The previous approach of checking if the diff was nil resulted in a false positive, which is avoided by basing the check on the length of the diff.
The checks for library.properties field formatting are skipped if the field is not present, but that was not possible with the required fields, since that is exactly what is being checked. So the checks should only be skipped if there is no library.properties at all.
per1234
force-pushed
the
per1234/fix-checks
branch
from
81faef8 to
be24c8e
Compare
silvanocerza
approved these changes
Dec 11, 2020
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.