Add --verbose flag #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Dec 10, 2020
It seems like the behavior that would be expected from the function.
Previously, the tool alway provides output for every check it runs. This is not necessarily a bad thing because in `--format text` mode it provides a progress indicator, and in `--format json` mode it provides information on all the checks that are run under the current tool configuration. However, as the number of checks grows, the amount of output has become a bit overwhelming and may make it hard to find the information for the failed checks. So it makes sense to default to only showing information on the failed checks while providing the option to show all checks.
per1234
force-pushed
the
per1234/add-verbose-flag
branch
from
bc2b283 to
7dcfd5f
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the tool alway provides output for every check it runs. This is not necessarily a bad thing because in
--format textmode it provides a progress indicator, and in--format jsonmode it provides information on all thechecks that are run under the current tool configuration.
However, as the number of checks grows, the amount of output has become a bit overwhelming and may make it hard to find
the information for the failed checks. So it makes sense to default to only showing information on the failed checks
while providing the option to show all checks.