github: Use IAM Roles to push files on AWS S3 #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For security reasons long lived credentials are not considered secure. To overcome this issue we can configure Github Workflows to use AWS OpenID Connect instead: For further details: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect
alessio-perugini
force-pushed
the
iam-roles
branch
from
9bb0a73 to
19f540a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
=======================================
Coverage 89.97% 89.97%
=======================================
Files 44 44
Lines 6772 6772
=======================================
Hits 6093 6093
Misses 555 555
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
had a problem deploying
to
production
GitHub Actions
Failure
alessio-perugini
had a problem deploying
to
production
GitHub Actions
Failure
alessio-perugini
had a problem deploying
to
production
GitHub Actions
Failure
alessio-perugini
temporarily deployed
to
production
GitHub Actions
Inactive
alessio-perugini
temporarily deployed
to
production
GitHub Actions
Inactive
alessio-perugini
temporarily deployed
to
production
GitHub Actions
Inactive
This reverts commit fa85b31.
cmaglie
reviewed
Dec 12, 2024
| PLUGIN_BUCKET: ${{ secrets.DOWNLOADS_BUCKET }} | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| run: aws s3 sync ${{ env.DIST_DIR }} s3://${{ secrets.DOWNLOADS_BUCKET }}${{ env.AWS_PLUGIN_TARGET }} |
There was a problem hiding this comment.
Can we check if env.DIST_DIR, secrets.DOWNLOADS_BUCKET, and env.AWS_PLUGIN_TARGET are defined?
There was a problem hiding this comment.
They are defined at the top of the workflow. I've also checked that the files are present in our s3 bucket.
https://github.com/arduino/arduino-lint/blob/iam-roles/.github/workflows/release-go-task.yml#L6-L12
The download_bucket is a secret that you can find defined in the settings of this repo.
cmaglie
approved these changes
Dec 12, 2024
alessio-perugini
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons long lived credentials are not considered secure.
To overcome this issue we can configure Github Workflows to use AWS OpenID Connect instead:
For further details: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect
Tested:
AWS_ACCESS_KEY,AWS_SECRET_KEY