Skip to content

Fix result package test #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Fix result package test #33

merged 1 commit into from
Nov 23, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 23, 2020

At the time the test was written, there was no validation of the project path argument, so a dummy path worked fine, but
now validation has been added so an existing path must be used.

The merge without rebasing of a PR in parallel to the PR that added the path validation resulted in a failing "Run tests" CI workflow, which is fixed by this PR.

At the time the test was written, there was no validation of the project path argument, so a dummy path worked fine, but
now validation has been added so an existing path must be used.
@per1234 per1234 requested a review from silvanocerza November 23, 2020 15:02
@per1234 per1234 merged commit 27150cc into main Nov 23, 2020
@per1234 per1234 deleted the per1234/fix-result-package-test branch November 23, 2020 15:13
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants