Skip to content

Add support for platform properties introduced for pluggable discovery #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 2, 2021
Merged

Add support for platform properties introduced for pluggable discovery #267

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ad66228
Fix typos in Go code doc comment
per1234 Aug 29, 2021
b5950b7
Add capability to test for required subproperties in platform.txt
per1234 Aug 29, 2021
72520b3
Add utility function for parsing properties lists
per1234 Aug 30, 2021
ce7a60f
Add rules for the `platform.txt` `pluggable_discovery.*` properties
per1234 Aug 30, 2021
d274953
Add parent check capability to required boards.txt property helper fu…
per1234 Aug 30, 2021
f5274ec
Add support for `upload.tool.<protocol_name>`
per1234 Aug 30, 2021
7c18e57
Move the "booleanString" schema to the general definitions file
per1234 Aug 31, 2021
1bdac6c
Increase mapping recursion depth of platform.txt tools.* properties
per1234 Aug 31, 2021
c7182c1
Add rules for user defined fields of Arduino platforms
per1234 Sep 1, 2021
cc2887c
Detect invalid `upload.<protocol_name>.x` properties
per1234 Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move the "booleanString" schema to the general definitions file 
This is an enum that contains the supported string representations of Boolean values. It was previously used only by the
boards.txt schema, and so was hosted in its file, but now there is a need for it in the platform.txt specification as
well, so it goes in the file that holds the shared definitions.
  • Loading branch information
@per1234
per1234 committed Sep 2, 2021
commit 7c18e57d5249198d095b86441e17fa9c658d2879
13 changes: 4 additions & 9 deletions etc/schemas/arduino-boards-txt-definitions-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -814,7 +814,7 @@
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -1016,7 +1016,7 @@
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -1057,7 +1057,7 @@
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -1215,11 +1215,6 @@
}
}
}
},
"enumObjects": {
"booleanString": {
"enum": ["true", "false"]
}
}
}
}
5 changes: 5 additions & 0 deletions etc/schemas/general-definitions-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
"pattern": "^[aA][rR][dD][uU][iI][nN][oO].*$"
}
}
},
"enumObjects": {
"booleanString": {
"enum": ["true", "false"]
}
}
}
}
18 changes: 9 additions & 9 deletions internal/rule/schema/schemadata/bindata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ var _arduinoBoardsTxtDefinitionsSchemaJson = []byte(`{
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -889,7 +889,7 @@ var _arduinoBoardsTxtDefinitionsSchemaJson = []byte(`{
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -1091,7 +1091,7 @@ var _arduinoBoardsTxtDefinitionsSchemaJson = []byte(`{
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -1132,7 +1132,7 @@ var _arduinoBoardsTxtDefinitionsSchemaJson = []byte(`{
"type": "string"
},
{
"$ref": "#/definitions/enumObjects/booleanString"
"$ref": "general-definitions-schema.json#/definitions/enumObjects/booleanString"
}
]
}
Expand Down Expand Up @@ -1290,11 +1290,6 @@ var _arduinoBoardsTxtDefinitionsSchemaJson = []byte(`{
}
}
}
},
"enumObjects": {
"booleanString": {
"enum": ["true", "false"]
}
}
}
}
Expand Down Expand Up @@ -6175,6 +6170,11 @@ var _generalDefinitionsSchemaJson = []byte(`{
"pattern": "^[aA][rR][dD][uU][iI][nN][oO].*$"
}
}
},
"enumObjects": {
"booleanString": {
"enum": ["true", "false"]
}
}
}
}
Expand Down