Skip to content

Provide object-level project index data to rules #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Provide object-level project index data to rules #188

merged 2 commits into from
Jun 11, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 11, 2021

Data checking rules for package indexes need to iterate over its object-level components. To facilitate this, slices of
such objects accompanied by the necessary metadata are generated as package index project data.

Several new fields must be added to the test table. The previous sparse formatting will not be suitable for the quantity
of data the test tables will need to hold.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 11, 2021
@per1234 per1234 requested review from silvanocerza and umbynos June 11, 2021 07:30
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #188 (4921733) into main (7dc9eae) will decrease coverage by 0.06%.
The diff coverage is 79.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   84.45%   84.39%   -0.07%     
==========================================
  Files          43       43              
  Lines        3082     3121      +39     
==========================================
+ Hits         2603     2634      +31     
- Misses        380      384       +4     
- Partials       99      103       +4     
Flag Coverage Δ
unit 84.39% <79.48%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/project/projectdata/packageindex.go 82.22% <79.48%> (-17.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc9eae...4921733. Read the comment docs.

Data checking rules for package indexes need to iterate over its object-level components. To facilitate this, slices of
such objects accompanied by the necessary metadata are generated as package index project data.
@per1234 per1234 merged commit e462881 into arduino:main Jun 11, 2021
@per1234 per1234 deleted the package-index-projectdata branch June 11, 2021 08:28
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants