[skip changelog] New release process that doesn't use goreleaser #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
force-pushed
the
scerza/new-release-process
branch
2 times, most recently
from
50a211a to
a69dde8
Compare
|
The "Check documentation links" workflow failure is expected. It's caused by the repositories being private. |
|
Demonstration release using this system (using my certificate and identity and with the AWS upload step disabled) available here: https://github.com/per1234/arduino-lint/releases/tag/0.1.0 |
per1234
force-pushed
the
scerza/new-release-process
branch
2 times, most recently
from
7b355a7 to
ff251f8
Compare
The previous case insensitive flag syntax is not supported in JavaScript regular expressions, resulting in an error from the `arduino/create-changelog` action: Invalid regular expression: /^(?i)\[(skip|changelog)[ ,-](skip|changelog)\].*/: Invalid group I couldn't find a valid way to specify the i flag, so I used the brute force approach to achieve case-insensitivity.
Although useful when used locally, when run in the headless GitHub Actions runner environment, this causes the command to fail: the input device is not a TTY
The "Build" step of the workflow relies on Task being installed. Without this step, the workflow fails: task: command not found
Previously, the Windows executables produced by the dist:Windows_32bit and dist:Windows_64bit tasks were named arduino-lint.
This is required for the correct output from `arduino-lint --version` with release versions of the tool.
The date in the filename would break the current installation script approach.
This is the naming convention established in Arduino CLI. Since neither format is superior to the other, and arduino-lint is using Arduino CLI as a reference (and likely the other way around as well in the future), it's best to be consistent.
per1234
force-pushed
the
scerza/new-release-process
branch
from
ff251f8 to
1058964
Compare
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #118.
This should be the new release process, it doesn't use
goreleaserand themultiarchcontainer to crosscompile but theelastic/golang-crossbuildcontainers to build for multiple platforms.It's currently working and could be used as is, but it needs some documentation.
Ideally this way of building can be easily used for the
arduino-cliwith minimal changes.