Define unique IDs for all check configurations #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
force-pushed
the
per1234/add-check-ids
branch
from
3c8178b to
eac06b7
Compare
per1234
changed the title
silvanocerza
suggested changes
Dec 15, 2020
During the course of development, the order of the check configurations in the array has become quite random. The checks are run in order of the configurations, so this is exposed to the user, and also makes the code a bit less easy to follow. The check functions and their tests have reordered to match the check configurations.
This information is currently only used for the JSON format output, so these changes have no implications for code.
- Undefined check ID - Incorrect check ID prefix - Duplicate check ID
During initial development, it was an unnecessary amount of work to assign unique IDs to each check configuration as it was added. Now that the bulk of the checks have been added, it's the time to do this.
per1234
force-pushed
the
per1234/add-check-ids
branch
from
eac06b7 to
14b046d
Compare
silvanocerza
approved these changes
Dec 15, 2020
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initial development, it was an unnecessary amount of work to assign unique IDs to each check configuration as it
was added. Now that the bulk of the checks have been added, it's the time to do this.
Tests are included to ensure check IDs are unique and have the standard prefix.