Skip to content

Improve readme #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Improve readme #106

merged 4 commits into from
Dec 21, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Dec 13, 2020

Verified

This commit was signed with the committer’s verified signature.
mp911de Mark Paluch

Verified

This commit was signed with the committer’s verified signature.
mp911de Mark Paluch

Verified

This commit was signed with the committer’s verified signature.
mp911de Mark Paluch
@per1234 per1234 force-pushed the per1234/improve-readme branch from 72124e7 to f0a9898 Compare December 20, 2020 11:29
@per1234
Copy link
Contributor Author

per1234 commented Dec 20, 2020

The "Check documentation links" workflow failure is expected. It's caused by the repositories being private.

@per1234 per1234 marked this pull request as ready for review December 20, 2020 11:33
@per1234 per1234 requested review from rsora and ubidefeo December 20, 2020 11:33
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have all the link working when we release the Github Action and deploy the documentation so LGTM!

@per1234 per1234 merged commit 20180bd into main Dec 21, 2020
@per1234 per1234 deleted the per1234/improve-readme branch December 21, 2020 12:40
@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants