Don't do project discovery when explicitly defined #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the project path discovery and type detection were done even when the user's settings explicitely defined these things. When the contents of the given path did not contain something slightly resembling a project of the given type, the process exited. That behavior is the only one possible when a project is not explicitely defined by the user, but in the case of an explicit definition, this is an unnecessary short circuiting of the process. The checks can still be run. This will result in the same exit status as before, but the check results may provide the user with helpful information about why their project is invalid.
silvanocerza
approved these changes
Dec 14, 2020
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the project path discovery and type detection were done even when the user's settings explicitely defined
these things. When the contents of the given path did not contain something slightly resembling a project of the given
type, the process exited.
That behavior is the only one possible when a project is not explicitely defined by the user, but in the case of an
explicit definition, this is an unnecessary short circuiting of the process. The checks can still be run. This will
result in the same exit status as before, but the check results may provide the user with helpful information about why
their project is invalid.