Skip to content

Disable autodownload of updates on startup #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Feb 23, 2022

Fixes #848

  • moved updater files to proper location
  • Autoupdater forced to download only after user confirmation

@fstasi fstasi requested review from AlbyIanna and per1234 February 23, 2022 16:46
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 24, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet figured out how to fully test the updater system, but this does fix #848 for me.

On startup or "Arduino: Check for Arduino IDE updates" command, I only get the expected check output, without the unexpected download:

Checking for update
Found version 2.0.0-rc4-nightly-20220224 (url: arduino-ide_nightly-20220224_Windows_64bit.exe)

I do get the download as expected when I run the "Arduino: Download Arduino IDE updates" command, and am then able to install it via the "Arduino: Install Arduino IDE updates" command.

Thanks Francesco!

Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AlbyIanna AlbyIanna merged commit 481497e into main Feb 24, 2022
@AlbyIanna AlbyIanna deleted the disable-startup-update branch February 24, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updater downloads IDE without user approval
3 participants