IDE to run CLI with auto assigned port #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbyIanna
reviewed
Dec 9, 2021
Comment on lines
117
to
123
| const { daemon, port } = await new SilentArduinoDaemonImpl( | ||
| 'json' | ||
| ).spawnDaemonProcess(); | ||
| expect(instance.port).not.to.be.undefined; | ||
| expect(instance.port).not.to.be.equal('0'); | ||
|
|
||
| expect(port).not.to.be.undefined; | ||
| expect(port).not.to.be.equal('0'); | ||
| daemon.kill(); |
There was a problem hiding this comment.
Maybe I'd prefer to put the new SilentArduinoDaemonImpl('json').spawnDaemonProcess(); in the beforeEach and the daemon.kill() in the afterEach.
@fstasi does it make sense to you?
There was a problem hiding this comment.
we actually run the SilentArduinoDaemonImpl with different input: json or text.. we can make a wrapper function probably
per1234
added
topic: CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It's not possible to make assumptions on what ports are available on the different OS the IDE can be run, and the default port 50051 is already in use in some cases (such as OS Monterey).
This issue is particularly annoying for first-time users that should go into the CLI configuration and change the port manually, before running the IDE.
How
The IDE now force the CLI daemon port to
0(automatically assigned from the OS). This ensure an available port is always picked up and the IDE can start normally, without manual intervention of the user