Skip to content

[ATL-1533] Firmware&Certificate Uploader #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 25, 2021
Merged
Prev Previous commit
reset fwuploader dialog once closed
  • Loading branch information
Alberto Iannaccone authored and fstasi committed Aug 23, 2021
commit bd21ce60d48d5055b7e2532880e479aaf9ddeb41
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ export const FirmwareUploaderComponent = ({
firmwareUploader,
updatableFqbns,
flashFirmware,
isOpen,
}: {
availableBoards: AvailableBoard[];
firmwareUploader: ArduinoFirmwareUploader;
updatableFqbns: string[];
flashFirmware: (firmware: FirmwareInfo, port: string) => Promise<any>;
isOpen: any;
}): React.ReactElement => {
// boolean states for buttons
const [firmwaresFetching, setFirmwaresFetching] = React.useState(false);
Expand All @@ -33,6 +35,9 @@ export const FirmwareUploaderComponent = ({
const [availableFirmwares, setAvailableFirmwares] = React.useState<
FirmwareInfo[]
>([]);
React.useEffect(() => {
setAvailableFirmwares([]);
}, [isOpen]);
const [selectedFirmware, setSelectedFirmware] =
React.useState<FirmwareOption | null>(null);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class UploadFirmwareDialogWidget extends ReactWidget {

protected updatableFqbns: string[] = [];
protected availableBoards: AvailableBoard[] = [];
protected isOpen = new Object();

public busyCallback = (busy: boolean) => {
return;
Expand Down Expand Up @@ -54,6 +55,11 @@ export class UploadFirmwareDialogWidget extends ReactWidget {
.finally(() => this.busyCallback(false));
}

onCloseRequest(msg: Message): void {
super.onCloseRequest(msg);
this.isOpen = new Object();
}

protected render(): React.ReactNode {
return (
<form>
Expand All @@ -62,6 +68,7 @@ export class UploadFirmwareDialogWidget extends ReactWidget {
firmwareUploader={this.arduinoFirmwareUploader}
flashFirmware={this.flashFirmware.bind(this)}
updatableFqbns={this.updatableFqbns}
isOpen={this.isOpen}
/>
</form>
);
Expand Down Expand Up @@ -119,6 +126,7 @@ export class UploadFirmwareDialog extends AbstractDialog<void> {
if (this.busy) {
return;
}
this.widget.close();
super.close();
}

Expand Down