Order custom board option menus as defined in platform configuration

[gneiss15]

The use of sort on configOptions caused the custom board options menus to be ordered according to the lexicographical order of the machine identifiers of the menus instead of allowing the platform developer to control the order in a manner that will be most friendly for human users (via the ordering in the boards.txt platform configuration file).

Removing the sorting code allows the order to be as intended by the platform developer, and aligns the behavior with that of Arduino IDE 1.x.

---

Fixes #2036

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[CLAassistant]

All committers have signed the CLA.

[gneiss15]

@per1234
Just one additional remark.
Before I found this "configOptions.sort...", I are confused about the order of the menu entries.
IMHO these should be either "as defined in boards.txt" (as in IDE 1.x) or alphabetical by name.
But it's sorted by the menu-id (label) instead of value.
Using a sort by value will produce a sorted order that is understandable by a human, but if that is what is wanted the documentation has to be adopted for this.

[per1234]

Thanks for your pull request @gneiss15. Unfortunately it doesn't appear to have fixed #2036.

If the change you propose had fixed #2036 then we would expect the custom board options menus to be ordered as they are in the Arduino IDE 1.8.19 Tools menu. For example, with Tools > Board > esp32 > ESP32 Dev Module selected from the Arduino IDE menus:

Note the order of the custom board menus:

• Upload Speed
• CPU Frequency
• Flash Frequency
• ...

However, when I use the tester build and select Tools > Board > esp32 > ESP32 Dev Module, the Tools menu contains:

Note the order of the custom board menus:

• CPU Frequency
• Core Debug Level
• Erase All Flash Before Sketch Upload
• ...

[gneiss15]

Hi @per1234,
in the meanwhile I had installed all the necessary tools for compiling and testing.
.. And yes my previous PR did not solve the problem.
Now I found, that removing the sort isn't enough, because that will not change the order inside the menu (only the order the confiOptions are processed).
Now I found (I am new to electron, typescript and so on), that the menu entries will be sorted by the last value of 'menuPath', which is currently '${option}'.
And that is the reason why they are sorted as shown above (by You). I now use '${order}`.
order is calculated from the current entry-number (or index of the entry inside configOptions).

So now the PR works as he should be.

PS.: The checks show some errors. I don’t know how to fix them, because they are not related to my PR