Skip to content

#1365 Show ports if has recognized board attached to it #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

#1365 Show ports if has recognized board attached to it #1377

merged 1 commit into from
Sep 1, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

Avoid filtering ports and the boards connected to them if the protocol is neither 'serial' nor 'network', but the associated boards are recognized.

Change description

Single sourced the port filtering.

Other information

Closes #1365

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Show ports if has recognized board attached to it.
e444956 
Closes #1365

 - Ref: 79ea0fa
 - Ref: 74bfdc4

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 31, 2022
davegarthsimpson
davegarthsimpson approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all makes sense

per1234
per1234 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1365

Thanks Akos!

I found that #1366 also no longer occurs after this change. However, I do not consider that bug fixed because there is no reason why the visibility of the port in the Board Selector interface should have an affect on whether the port remains selected after an upload. I am still able to reproduce #1366 if I remove the board identification property from the board definition of the Teensy in its boards.txt.

@kittaakos
Copy link
Contributor Author

I am still able to reproduce #1366 if I remove the board identification property from the board definition of the Teensy in its boards.txt.

Do you want me to look into #1366 in the context of this PR? It's up to you, whichever makes the verification easier.

@per1234
Copy link
Contributor

per1234 commented Aug 31, 2022

look into #1366 in the context of this PR?

I recommend doing it separately. We already have wrapped this one up and it does exactly what it was intended to do.

I noticed the change to the state of #1366 by chance during the review.

I will add a more detailed report to #1366 about the newly discovered information.

@per1234 per1234 mentioned this pull request Sep 1, 2022
Closed
3 tasks
@kittaakos kittaakos merged commit 0d545be into main Sep 1, 2022
@kittaakos kittaakos deleted the #1365 branch September 1, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identified ports of protocols other than serial or network not shown in Board Selector
3 participants
@kittaakos @per1234 @davegarthsimpson