Skip to content

fix 180: prevent erroneous "auto-reconnect"(s) in board selector #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 24, 2022
Merged

fix 180: prevent erroneous "auto-reconnect"(s) in board selector #1328

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
afb3ef7
ensure auto-select doesn't select wrong port
davegarthsimpson Aug 11, 2022
189a6f2
Merge branch 'main' into 180-board-selection
davegarthsimpson Aug 16, 2022
09534c6
clean up
davegarthsimpson Aug 16, 2022
e9137f7
add "uploadInProgress" prop to boards change event
davegarthsimpson Aug 16, 2022
b15603c
remove unused methods and deps
davegarthsimpson Aug 16, 2022
b7b155c
[WIP]: leverage upload event to derived new port
davegarthsimpson Aug 22, 2022
bbeabd9
remove timeout
davegarthsimpson Aug 22, 2022
03f82fc
refine port selection logic
davegarthsimpson Aug 22, 2022
cac5dab
clean up naming
davegarthsimpson Aug 23, 2022
a414c87
refine port selection logic & add delayed clean up
davegarthsimpson Aug 23, 2022
b002fca
renaming & refactoring
davegarthsimpson Aug 23, 2022
c5fbad7
method syntax & remove unnecessary methods
davegarthsimpson Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into 180-board-selection
  • Loading branch information
@davegarthsimpson
davegarthsimpson committed Aug 16, 2022
commit 189a6f2eac9908468852ee550f66168b87c626e9
1 change: 1 addition & 0 deletions arduino-ide-extension/src/browser/contributions/upload-sketch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ export class UploadSketch extends CoreServiceContribution {
this.uploadInProgress = true;
this.onDidChangeEmitter.fire();
this.notificationCenter.notifyUploadInProgress(this.uploadInProgress);
this.clearVisibleNotification();

const verifyOptions =
await this.commandService.executeCommand<CoreService.Options.Compile>(
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.