Fix wrong return values for WiFi::softAPConfig

me-no-dev · me-no-dev · commit 1f0df1ef976b · 2017-02-10T13:49:43.000+02:00
fixes: espressif#191
diff --git a/libraries/WiFi/src/WiFiAP.cpp b/libraries/WiFi/src/WiFiAP.cpp
@@ -154,8 +154,8 @@ bool WiFiAPClass::softAPConfig(IPAddress local_ip, IPAddress gateway, IPAddress
     info.gw.addr = static_cast<uint32_t>(gateway);
     info.netmask.addr = static_cast<uint32_t>(subnet);
     tcpip_adapter_dhcps_stop(TCPIP_ADAPTER_IF_AP);
-    if(tcpip_adapter_set_ip_info(TCPIP_ADAPTER_IF_AP, &info)) {
-        return tcpip_adapter_dhcps_start(TCPIP_ADAPTER_IF_AP);
+    if(tcpip_adapter_set_ip_info(TCPIP_ADAPTER_IF_AP, &info) == ESP_OK) {
+        return tcpip_adapter_dhcps_start(TCPIP_ADAPTER_IF_AP) == ESP_OK;
     }
     return false;
 }

Original file line number	Diff line number	Diff line change
`@@ -154,8 +154,8 @@ bool WiFiAPClass::softAPConfig(IPAddress local_ip, IPAddress gateway, IPAddress`
`154`	`154`	`info.gw.addr = static_cast<uint32_t>(gateway);`
`155`	`155`	`info.netmask.addr = static_cast<uint32_t>(subnet);`
`156`	`156`	`tcpip_adapter_dhcps_stop(TCPIP_ADAPTER_IF_AP);`
`157`		`- if(tcpip_adapter_set_ip_info(TCPIP_ADAPTER_IF_AP, &info)) {`
`158`		`- return tcpip_adapter_dhcps_start(TCPIP_ADAPTER_IF_AP);`
	`157`	`+ if(tcpip_adapter_set_ip_info(TCPIP_ADAPTER_IF_AP, &info) == ESP_OK) {`
	`158`	`+ return tcpip_adapter_dhcps_start(TCPIP_ADAPTER_IF_AP) == ESP_OK;`
`159`	`159`	`}`
`160`	`160`	`return false;`
`161`	`161`	`}`