Skip to content

Implementation of port discovery through Pluggable discovery #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 22 commits into from
Mar 20, 2024
Merged

Implementation of port discovery through Pluggable discovery #900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
670fe39
Upgraded arduino-cli and replaced serialutils dep
cmaglie Feb 7, 2024
17f261c
Refined ports filter
cmaglie Feb 7, 2024
8b32baf
Silenced linter warning
cmaglie Feb 7, 2024
b0e9d0a
Use pointers in ports lists
cmaglie Feb 7, 2024
87f178b
Made spList a method of SpPortList
cmaglie Feb 7, 2024
0622368
Renamed SpPortList in SerialPortList
cmaglie Feb 7, 2024
5946a68
Removed unneded initialization
cmaglie Feb 7, 2024
8bde36f
Inlined discovery loop
cmaglie Feb 7, 2024
1796891
Made updateSerialPortList a method of SerialPortList
cmaglie Feb 7, 2024
b74c406
Made enumerationLock private
cmaglie Feb 7, 2024
d1cd49f
Made portsLock (ex Mu) field private
cmaglie Feb 7, 2024
88556d9
Inlined function call
cmaglie Feb 7, 2024
c3f2c48
Made findPortByName a method of serialhub and moved near it
cmaglie Feb 8, 2024
1885e13
Inlined call to 'write' and removed the function
cmaglie Feb 8, 2024
9e06768
Removed unused ManufacutrerId and DeviceClass, renamed some fields
cmaglie Feb 8, 2024
d723283
Simplified enumerateSerialPorts function
cmaglie Feb 8, 2024
d7a9991
Removed redundant loggin of serial port list
cmaglie Feb 8, 2024
6cc7a9e
Removed seriallist.go and inlined function calls
cmaglie Feb 8, 2024
c2b4096
Make the singleton 'tools' a pointer
cmaglie Feb 8, 2024
aba64eb
Implemented serial-discovery
cmaglie Feb 12, 2024
57e9bd9
Remove no more used 'Busy' field
cmaglie Feb 12, 2024
36bdf7b
Fixed error message
cmaglie Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the singleton 'tools' a pointer
  • Loading branch information
@cmaglie
cmaglie committed Mar 20, 2024
commit c2b4096ea617877b479c0c6669b40cd4f8dfb1c6
2 changes: 1 addition & 1 deletion conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func uploadHandler(c *gin.Context) {

go func() {
// Resolve commandline
commandline, err := upload.PartiallyResolve(data.Board, filePath, tmpdir, data.Commandline, data.Extra, &Tools)
commandline, err := upload.PartiallyResolve(data.Board, filePath, tmpdir, data.Commandline, data.Extra, Tools)
if err != nil {
send(map[string]string{uploadStatusStr: "Error", "Msg": err.Error()})
return
Expand Down
4 changes: 2 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ var homeTemplateHTML string

// global clients
var (
Tools tools.Tools
Tools *tools.Tools
Systray systray.Systray
Index *index.Resource
)
Expand Down Expand Up @@ -252,7 +252,7 @@ func loop() {

// Instantiate Index and Tools
Index = index.Init(*indexURL, config.GetDataDir())
Tools = *tools.New(config.GetDataDir(), Index, logger)
Tools = tools.New(config.GetDataDir(), Index, logger)

// see if we are supposed to wait 5 seconds
if *isLaunchSelf {
Expand Down