Rewrite of download #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
Download from http://downloads.arduino.cc/packages/package_index.json Update the Installed Map at startup
|
Test FAILed. |
2 similar comments
|
Test FAILed. |
|
Test FAILed. |
|
✅ Build completed. Download at http://downloads.arduino.cc/CreateBridge/CreateBridge-PR115.zip |
|
Merged as #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the code to download tools into a package.
The downloadtool works mostly like before, with the only difference that now it ignores the url provided to it relying instead on a configuration variable.
Usage:
This command is sent from websocket
The agent will parse the package_index.json in the configuration, will retrieve the latest version of the tool and it will download it.
It will check the Sha-256 checksum to ensure that the file hasn't been corrupted or tampered with.
Right now it's not used but there is the possibility to specify a certain version of a tool, in order to keep them versioned for boards needing an older version, for example.
You can test it with this release: https://github.com/arduino/arduino-create-agent/releases/tag/test-3
Fix #72