Skip to content

[EDITOR-503] fix wrong agent version in spotlight [MacOs] #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2021
Merged

[EDITOR-503] fix wrong agent version in spotlight [MacOs] #613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf15bcf
fix wrong agent version in spotlight [MacOs]
umbynos Feb 4, 2021
224a406
forgot space 🤦🏻‍♂️
umbynos Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,33 @@ jobs:
run: mv -v ${{ matrix.executable-path }}arduino-create-agent_cli${{ matrix.extension }} ${{ matrix.executable-path }}Arduino_Create_Agent_cli${{ matrix.extension }}
if: matrix.os == 'ubuntu-18.04'

- name: get year
run: echo "YEAR=$(date "+%Y")" >> $GITHUB_ENV
if: matrix.os == 'macos-10.15'

- name: Generate Info.plist for MacOS
run: |
cat > skel/ArduinoCreateAgent.app/Contents/Info.plist <<EOF
<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"><plist version="1.0"><dict><key>CFBundlePackageType</key><string>APPL</string><key>CFBundleInfoDictionaryVersion</key><string>6.0</string>

<key>CFBundleIconFile</key> <string>AppIcon.icns</string>

<key>CFBundleName</key> <string>Arduino Create Agent</string>
<key>CFBundleExecutable</key> <string>Arduino_Create_Agent</string>
<key>CFBundleIdentifier</key> <string>create.arduino.cc</string>

<key>CFBundleVersion</key> <string>${GITHUB_REF##*/}</string>
<key>NSHumanReadableCopyright</key> <string>© Copyright ${{ env.YEAR }} Arduino LLC</string>
<key>CFBundleShortVersionString</key> <string>${GITHUB_REF##*/}</string>
<key>LSUIElement</key> <true/>
<!-- Needed for Apache Callback -->
<key>NSPrincipalClass</key><string>NSApplication</string>
<key>NSMainNibFile</key><string>MainMenu</string>

</dict></plist>
EOF
if: matrix.os == 'macos-10.15'

- name: Save InstallBuilder license to file
run: echo "${{ secrets.INSTALLER_LICENSE }}" > /tmp/license.xml

Expand Down