Skip to content

compile_webidebridge.sh: don't require all platforms compilers #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jan 13, 2016

So one can build the tool without preparing all cross compilers.

Signed-off-by: Riccardo Magliocchetti riccardo.magliocchetti@gmail.com

@mastrolinux
Copy link
Contributor

nice, can you please add a ALL option to allow building for every platform quickly?
@xrmx

xrmx added 2 commits January 25, 2016 13:53
So one can build the tool without preparing all cross compilers.

Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@xrmx
Copy link
Contributor Author

xrmx commented Jan 25, 2016

Il 25/01/2016 13:03, Luca Cipriani ha scritto:

nice, can you please add a ALL option to allow building for every platform quickly?

I don't think handling an "all" target in compilePlatform would be cleaner, i've
updated the pull request moving the check inside compilePlatform and adding a
wrapper that would compile every target. What do you think?

Riccardo Magliocchetti
@rmistaken

http://menodizero.it

@matteosuppo
Copy link
Contributor

I'm afraid it wouldn't work for Linux ARM, because the check would become which 0

@xrmx
Copy link
Contributor Author

xrmx commented Feb 3, 2016

@matteosuppo nice catch! Anyway feel free to cherry-pick whatever you think is valuable in this pull request otherwise just close it.

@matteosuppo
Copy link
Contributor

I'm closing it because we can now simply build it with go build, and the continuous integration server do not use compile_webidebridge.sh anymore.

@matteosuppo matteosuppo closed this Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants