Make it clear that bash is required #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows is smart enough to add trailing .exe, so we'll be able to add different commandlines depending on host OS
this should solve problems with slower (or Win based) systems
will be used during installation to trigger a new certificate creation
Configurable cors
Add configurable CORS allowed origins
The one char fix @matteosuppo
Be sure we have a comma + space separated list
add generateCert commandline switch
Give the correct port for upload
Certificates
Use a different key
Certificates
|
Should i rebase this to devel? |
|
yes please, make the PR to devel and we will merge it |
The script contains some bashims like echo -e so better make it explicit. Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
|
It looks i cannot change target branch of a pull request, closing and opening a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script contains some bashims like echo -e so better make it
explicit.
Signed-off-by: Riccardo Magliocchetti riccardo.magliocchetti@gmail.com