-
-
Notifications
You must be signed in to change notification settings - Fork 150
Only attempt SSH upload on Yun boards #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only attempt SSH upload on Yun boards #100
Conversation
Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>
Can we pass a generic list of sshallowedboards instead of directly putting the board name in a piece of code? It will be hard to maintain. Good catch! |
Good idea, which one of the following were you thinking of?
|
It might actually better for the client to specify SSH or HTTP instead of the current generic type of "network". |
array in programmer.go is fine for me. If it grows we can always move it to the config file in the future. |
Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>
c0aaea8
to
f9da80c
Compare
@mastrolinux array added in f9da80c |
@facchinm does the Yun 101 have the same fqbn as the original Yun ( |
The Yun101 has |
fee3d17
to
b0b3b31
Compare
This PR is obsolete, and the Yun 101 has never seen the light of the day. Closing. RIP. |
Previously SSH uploads were attempted on Yun Shields if the HTTP method failed. However, this causes the following error on non-ATmega32u4 based boards:
I think we should only be using SSH for the original Yun board.