Skip to content

Only attempt SSH upload on Yun boards #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sandeepmistry
Copy link
Contributor

@sandeepmistry sandeepmistry commented May 13, 2016

Previously SSH uploads were attempted on Yun Shields if the HTTP method failed. However, this causes the following error on non-ATmega32u4 based boards:

merge-sketch-with-bootloader.lua /tmp/sketch.hex && /usr/bin/run-avrdude /tmp/sketch.hex
INFO[1635] Command finished with error: Process exited with: 1. Reason was:  () 

I think we should only be using SSH for the original Yun board.

Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>
@mastrolinux
Copy link
Contributor

Can we pass a generic list of sshallowedboards instead of directly putting the board name in a piece of code? It will be hard to maintain.

Good catch!

@sandeepmistry
Copy link
Contributor Author

Can we pass a generic list of sshallowedboards instead of directly putting the board name in a piece of code?

Good idea, which one of the following were you thinking of?

  • Array in programmer.go
  • Config. file entry in config.ini
  • sshallowedboards parameter in the /update REST request
  • Something else?

@sandeepmistry
Copy link
Contributor Author

It might actually better for the client to specify SSH or HTTP instead of the current generic type of "network".

@mastrolinux
Copy link
Contributor

array in programmer.go is fine for me. If it grows we can always move it to the config file in the future.

Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>
@sandeepmistry sandeepmistry force-pushed the yun-shield-no-ssh-upload branch from c0aaea8 to f9da80c Compare May 16, 2016 15:51
@sandeepmistry
Copy link
Contributor Author

@mastrolinux array added in f9da80c

@sandeepmistry
Copy link
Contributor Author

@facchinm does the Yun 101 have the same fqbn as the original Yun (arduino:avr:yun)?

@facchinm
Copy link
Member

The Yun101 has arduino:avr:yun101 as fqbn but keeps the same build variables of the original Yun (so code is 100% compatible except USB PID)

@facchinm facchinm removed their assignment Oct 3, 2018
@matteosuppo matteosuppo force-pushed the devel branch 4 times, most recently from fee3d17 to b0b3b31 Compare April 6, 2020 15:52
@zmoog
Copy link
Contributor

zmoog commented Jan 15, 2021

This PR is obsolete, and the Yun 101 has never seen the light of the day. Closing.

RIP.

@zmoog zmoog closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants