Skip to content

Implement connection/disconnection callbacks for web serial daemon #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Implement connection/disconnection callbacks for web serial daemon #545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbd0508
WIP - Added connect/disconnect callback (working)
csarnataro Apr 20, 2022
4014157
Implemented connection/disconnection callbacks via messages in web se…
csarnataro Apr 21, 2022
7b084f1
Bumped version to 2.8.1
csarnataro Apr 21, 2022
0c486b0
Temporarily adding bundles to be used from internal CI
csarnataro Apr 21, 2022
0952c7b
Sending data to serial monitor
csarnataro Apr 22, 2022
7f375cf
Implemented closeAllPorts
csarnataro Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Implemented closeAllPorts
  • Loading branch information
@csarnataro
csarnataro committed Apr 24, 2022
commit 7f375cf6664cfd795c7f61fb3099392fc13f87c0
1 change: 1 addition & 0 deletions es/web-serial-daemon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ var WebSerialDaemon = /*#__PURE__*/function (_Daemon) {
key: "closeAllPorts",
value: function closeAllPorts() {
console.log('should be closing serial ports here');
this.uploader.closeAllPorts();
}
/**
* Request serial port open
Expand Down
1 change: 1 addition & 0 deletions src/web-serial-daemon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export default class WebSerialDaemon extends Daemon {
// eslint-disable-next-line class-methods-use-this
closeAllPorts() {
console.log('should be closing serial ports here');
this.uploader.closeAllPorts();
}

/**
Expand Down