Move base files and vendor @sandeepmistry paho mqtt fork

[facchinm]

(until they merge the patch)

To compile:
clone the repo

cd arduino-connector
export GOPATH=$PWD
go get github.com/bcmi-labs/arduino-connector
go build github.com/bcmi-labs/arduino-connector

Jenkins build is on the go

[matteosuppo]

Wait, why don't you just use the vendor directory? https://golang.org/cmd/go/#hdr-Vendor_Directories

[sandeepmistry]

Could we also use a Git submodule for the Paho fork?

[matteosuppo]

But why

[facchinm]

Wait, why don't you just use the vendor directory?

I'm using it 😛

[matteosuppo]

Yeah but you moved everything into a src/github.com folder. Why?

[facchinm]

Ah, I did that because otherwise the vendor directory was not picked up (feel free to refactor the patch completely anyway if you have a better method 😄 )

[facchinm]

This looks wrong, we must use the forked one

[matteosuppo]

It wouldn't work since the code is still importing github.com/eclipse/paho.mqtt.golang
We are actually using the forked version in the vendor folder (you can check).

It's like this since this is a temporary fork while waiting for an upstream merge. If we were to maintain another fork we should have changed all the imports to github.com/bcmi-labs/paho.mqtt.golang (or wherever the forked repo is).

Just to be clear, if we were to remove the vendor folder and restore it from the lock file, it wouldn't work (as you suspected). But it wouldn't work in any other way :S I'm not sure how we could make it look less wrong.

[matteosuppo]

Can we merge it now?

[facchinm]

http://jenkins.arduino.cc:8080/job/arduino-connector/ is behaving just ok with the current codebase (can be further simplified when the project will be opensourced and could be go-getted). I'd close this one instead than merging... Poll 😄 ?