This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Uninstall #288
Closed
Uninstall #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerinoni
force-pushed
the
feature/80
branch
2 times, most recently
from
34f0f99 to
c005a37
Compare
guerinoni
force-pushed
the
feature/80
branch
3 times, most recently
from
7b926b2 to
d0d2df7
Compare
guerinoni
requested review from
pippolo84 and
rsora
and removed request for
pippolo84
guerinoni
force-pushed
the
feature/80
branch
2 times, most recently
from
c20c9eb to
432f46c
Compare
added 18 commits
October 5, 2020 10:16
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Last step of uninstall function is to generate a script, for now in executable folder, that user should run to remove arduino-connector. Signed-off-by: Federico Guerinoni <guerra@develer.com>
For now during installation will be create a file with local config for arduino-connector checking if docker is already installed. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
In this case I separate with name the tests that should run on docker container based on ubuntu and the tests for alpine based container, in this case I tested the list of images when nothing is installed and when one image are already present. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
I tested the presence of this package with a dpkg command in ubuntu docker container and add it in yml file as boolean. Signed-off-by: Federico Guerinoni <guerra@develer.com>
This test checks uninstall API will remove all containers in config file. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
In this case when install docker images and containers lists are both empty because there I will store only what application installs. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
pippolo84
suggested changes
Oct 5, 2020
pippolo84
left a comment
pippolo84
left a comment
There was a problem hiding this comment.
Please review and (eventually) apply the suggested changes.
Signed-off-by: Federico Guerinoni <guerra@develer.com>
guerinoni
force-pushed
the
feature/80
branch
4 times, most recently
from
5e5a6b2 to
a2b3ee3
Compare
Signed-off-by: Federico Guerinoni <guerra@develer.com>
added 2 commits
October 15, 2020 17:50
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
|
|
Contributor
Author
|
@rsora maybe we can merge it? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solve #80, in order to uninstall only packages installed through arduino-connector during installation will create a config file listing packages already present, like network-manager, docker (images + container), and so on...
The uninstall feature is called by API
/status/uninstall/postand at the end of the uninstall process it creates a script (uninstall-arduino-connector.sh) for the user that must run to finalize the uninstall process. This because is impossible to stop and remove service from within arduino-connector, that script removes also the binary.