This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Feature/tests apt #284
Merged
Feature/tests apt #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsora
suggested changes
Sep 1, 2020
.github/workflows/tests.yml
Outdated
| apt-tests: | ||
| name: apt-tests | ||
| runs-on: ubuntu-latest | ||
| container: guerra1994/go-mosquitto-ubuntu-env |
Contributor
There was a problem hiding this comment.
Can you please add the Dockerfile for this Image?
Contributor
Author
There was a problem hiding this comment.
@rsora
I added this Dockerfile but there is also another image and is not a simple docker file. For now, docker images are hosted on my GH https://github.com/guerinoni/go-mqtt-docker-env and https://github.com/guerinoni/go-mosquitto-ubuntu-env, if you want we can move this repo in arduino GH or add it as submodules
As you prefer...
Contributor
There was a problem hiding this comment.
Please add them under the Arduino org, documenting, and providing links in the readme in a proper section. 👍
rsora
approved these changes
Sep 1, 2020
guerinoni
force-pushed
the
feature/tests-apt
branch
from
987225c to
5b02e9d
Compare
guerinoni
force-pushed
the
feature/tests-apt
branch
from
5b02e9d to
1f18038
Compare
added 11 commits
September 17, 2020 18:31
Signed-off-by: Federico Guerinoni <guerra@develer.com>
This type of test should be performed on docker container guerra1994/go-mosquitto-ubuntu-env or in local machine properly configured. Signed-off-by: Federico Guerinoni <guerra@develer.com>
In this case I also renamed functional-tests script in docker-tests because is more consistent. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
It seems that repository is already removed but is not right because in /etc/apt/sources.list.d/managed.list is still present. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
guerinoni
force-pushed
the
feature/tests-apt
branch
from
b32aa60 to
de68dfd
Compare
pippolo84
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the first part of tests for apt APIT