This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Move binary in /usr/bin #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsora
approved these changes
Sep 1, 2020
guerinoni
force-pushed
the
feature/234
branch
from
baac4d0 to
730b53b
Compare
added 2 commits
September 16, 2020 18:53
This fix #234, in this way the path for service is /usr/bin and during script of installation will be moved in that path. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Signed-off-by: Federico Guerinoni <guerra@develer.com>
guerinoni
force-pushed
the
feature/234
branch
from
730b53b to
ca0bd5f
Compare
rsora
approved these changes
Sep 17, 2020
pippolo84
suggested changes
Sep 17, 2020
pippolo84
left a comment
pippolo84
left a comment
There was a problem hiding this comment.
The WorkingDirectory is wrong. We need to address that issue before merging.
install.go
Outdated
| Description: "Cloud connector and launcher for IoT devices.", | ||
| Arguments: []string{"-config", configFile}, | ||
| WorkingDirectory: workingDirectory, | ||
| WorkingDirectory: "/usr/bin", |
There was a problem hiding this comment.
The WorkingDirectory must be the path where the certificates and arduino-connector.cfg are. Probably we should create a dedicated folder where to move those files (in the installation script) and save that path here.
Signed-off-by: Fabio Falzoi <fabio@develer.com>
pippolo84
approved these changes
Sep 17, 2020
Signed-off-by: Fabio Falzoi <fabio@develer.com>
This because GHCR are still buggy, maybe the images is moved under the hood and every pulls fail because unknowk blob. Signed-off-by: Federico Guerinoni <guerra@develer.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #234, in this way the path for service is /usr/bin and during
script of installation will be moved in that path.
Signed-off-by: Federico Guerinoni guerra@develer.com