This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Permission fixes #24
Closed
Permission fixes #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this bit on the sketches directory, no files can be created inside it: ERROR: download file https://api-builder.arduino.cc/builder/v1/compile/sketch_dec12a.bin: create /path/to/arduino-connector/sketches/sketch_dec12a: open /path/to/arduino-connector/sketches/sketch_dec12a: permission denied The db directory and the file inside it simply does not seem to be created. In general, all directories should have +x to allow accessing files inside.
There is no need to make this file executable.
It makes no sense to use 744 (rx for self, r only for group and others), and the arduino-connector.sh install script initially creates with 755 as well.
There is no real point in making this world-readable, so it is probably better to keep the data private.
matthijskooijman
force-pushed
the
permission-fixes
branch
from
a28c6a5 to
9c0221d
Compare
In practice, a umask also applies to these permissions, so it would not be world-writable anyway. Better to enforce this, and remove the world-readability at the same time. Also, having this directory world-writable could very well become a (part of) security problem.
matthijskooijman
force-pushed
the
permission-fixes
branch
from
9c0221d to
e570e8f
Compare
Member
|
Manually merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes or improves some of the permissions used by the connector. The permissions on the sketches folder are needed to make things work. I haven't done extensive testing, but basic sketch uploading and running works.