Skip to content

Search for config file #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Search for config file #60

merged 1 commit into from
Nov 30, 2021

Conversation

glumia
Copy link
Contributor

@glumia glumia commented Nov 12, 2021

Motivation

It's cumbersome to carry around or symlink the configuration file wherever I (a user) want to use the cloud CLI.

This allows us to keep it in one single place and launch commands from wherever we like.

Change description

  • Search for config file (arduino-cloud.yaml or arduino-cloud.json) in the current directory, its parents or in .arduino15.

Additional notes

Some pieces were taken from github.com/arduino/arduino-cli/configuration.

It would be nice in the future to export a method from arduino-cli to get its configuration directory, in order to not duplicate this logic here.

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@glumia glumia force-pushed the glumia/search-config branch from cd41c38 to d8e15dd Compare November 12, 2021 15:32
@polldo
Copy link
Contributor

polldo commented Nov 12, 2021

I ❤️ you

@glumia glumia force-pushed the glumia/search-config branch 5 times, most recently from b9cb2c1 to 5176845 Compare November 30, 2021 08:40
Some pieces were taken from
`github.com/arduino/arduino-cli/configuration`.
@glumia glumia force-pushed the glumia/search-config branch from 5176845 to 2847a52 Compare November 30, 2021 17:49
@glumia glumia merged commit c42f685 into main Nov 30, 2021
@glumia glumia deleted the glumia/search-config branch November 30, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants