[skip changelog] Pin platform versions used in integration tests #879
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents spurious test breakage caused by platform releases. These tests are about the behavior of Arduino CLI itself, not about testing the platform, so the platform should be static. There are certain tests which make sense to do with the latest release of the platforms, and those have been left as is.
silvanocerza
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Bug fix.
The
test_compile_without_precompiled_librariesintegration test fails due to a release of the arduino:mbed platform that introduces an incompatibility with the Arduino_LSM9DS1 library used by that test. This failure has nothing to do with any change to Arduino CLI and doesn't indicate any problem with Arduino CLI, so it's not helpful.Where appropriate, platforms used by tests are pinned. This fixes the spurious test failure.
In some integration tests, using the latest version of a platform is appropriate and useful. In those cases, the platform was not pinned.
No.
References: