Removed automatic '--relax' hack for compiles on Atmega2560 MCU #749
Conversation
There was a problem hiding this comment.
Code looks good.
I would suggest adding the following to the commit message:
This removes the
--relaxoption, potentially producing slightly bigger code for the atmega2560. On the longer term, the AVR core should just add this option for all boards, but this is not currently the case yet because removing--relaxalso works around a gcc miscompilation (see arduino/ArduinoCore-avr#339).
Do you mean the gcc7 we use? Or later versions? Since with gcc7, removing |
|
Hm, did you intentionally not include my suggested addition to the commit message? Should I have just pushed it to the branch directly (I think I could have)? |
|
I added it in the squash |
|
Ah, should have checked the master history. I had somehow assumed that this would have looked differently for a squash commit, but apparently not. Sorry for that, and thanks! :-) |
- Removed automatic '--relax' hack for compiles on Atmega2560 MCU arduino/arduino-cli#749 - Fixed skethbook+bootloader hex merger. arduino/arduino-cli#744 - Fixed race condition in legacy i18n.LoggerToCustomStreams arduino/arduino-cli#704 - Fixed path-relativization error when traversing different partitions arduino/arduino-cli#658 - Add macro during lib discovery phase arduino/arduino-cli#633 - legacy: Improved progress report from Compile arduino/arduino-cli#625
This removes the --relax option, potentially producing slightly bigger code for the atmega2560. On the longer term, the AVR core should just add this option for all boards, but this is not currently the case yet because removing --relax also works around a gcc miscompilation (see arduino/ArduinoCore-avr#339). Close: #639
As discussed in: #639
This change has no effects on all board with MCU != Atmega2560.
AFAIU the
--relaxoption should be no more needed with the latest available avr compilers.