Remove ignored Configuration GRPC API #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsora
force-pushed
the
remove-ignored-grpc-apis
branch
from
8956017 to
6f42ae3
Compare
|
@cmaglie rebased on master to include latest changes and re-generated proto files! |
cmaglie
commented
Jan 17, 2020
go.mod
Outdated
| @@ -47,6 +47,7 @@ require ( | |||
| go.bug.st/serial.v1 v0.0.0-20180827123349-5f7892a7bb45 // indirect | |||
| golang.org/x/net v0.0.0-20190311183353-d8887717615a | |||
| golang.org/x/text v0.3.0 | |||
| google.golang.org/appengine v1.4.0 // indirect | |||
There was a problem hiding this comment.
Why this appengine keeps coming back? Are we using it?
|
I can't approve my own PR, anyway the rebase seems ok, we can merge IMHO. |
|
Ok to remove because we're 0.x, but the reason why I deprecated it instead of killing with fire was to avoid breaking clients that were not using the Config message (it was the case of the PRO ide). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we have the
Configurationfield inInitReqthat is marked as deprecated but it's actually not supported anymore.IMHO if we want to deprecate it we should not silently ignore it otherwise, from the client perspective, it seems that the command has been accepted, leading to a hard to diagnose errors.
Otherwise, if we don't want to support it anymore it's better to merge this PR and remove it altogether so we have a clear indicator that the old API is no longer available.