-
-
Notifications
You must be signed in to change notification settings - Fork 414
Extract and extend license and copyright #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest Buf updates on your PR. Results from workflow Check Protocol Buffers / check (pull_request).
|
f9540cc
to
1b80d24
Compare
4edf904
to
ed61192
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2959 +/- ##
==========================================
- Coverage 68.22% 68.21% -0.02%
==========================================
Files 241 241
Lines 22696 22696
==========================================
- Hits 15484 15481 -3
- Misses 6012 6014 +2
- Partials 1200 1201 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
62dd1a7
to
639bc19
Compare
Co-authored-by: Luca Rinaldi <lucarin@protonmail.com>
Co-authored-by: Luca Rinaldi <lucarin@protonmail.com>
a5aaceb
to
3140dd5
Compare
append-license: | ||
desc: Render and append arduino-cli license to NOTICE file | ||
cmds: | ||
- | | ||
rendered=$(envsubst < .licenses/templates/arduino-cli-license.txt) | ||
notice_file=".licenses/NOTICE.arduino-cli" | ||
tmp_file=$(mktemp) | ||
echo "$rendered" > "$tmp_file" | ||
echo -e "\n" >> "$tmp_file" | ||
cat "$notice_file" >> "$tmp_file" | ||
mv "$tmp_file" "$notice_file" | ||
env: | ||
Year: '{{ now | date "2006" }}' | ||
Holder: "ARDUINO SA (http://www.arduino.cc/)" | ||
silent: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this autogeneration system will be useful. I would just commit a copyright notice file without the env variable and use that during the build.
append-license: | |
desc: Render and append arduino-cli license to NOTICE file | |
cmds: | |
- | | |
rendered=$(envsubst < .licenses/templates/arduino-cli-license.txt) | |
notice_file=".licenses/NOTICE.arduino-cli" | |
tmp_file=$(mktemp) | |
echo "$rendered" > "$tmp_file" | |
echo -e "\n" >> "$tmp_file" | |
cat "$notice_file" >> "$tmp_file" | |
mv "$tmp_file" "$notice_file" | |
env: | |
Year: '{{ now | date "2006" }}' | |
Holder: "ARDUINO SA (http://www.arduino.cc/)" | |
silent: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the comments and move to another directory? I think the root directory is ok. I would also remove the env variables and just create a file with the copyright notice all filled up.
- mkdir -p debian/arduino-cli/usr/share/doc/arduino-cli/ | ||
- cat arduino-cli-license.txt > debian/arduino-cli/usr/share/doc/arduino-cli/copyright | ||
- echo -e "\n\n---\n\n" >> debian/arduino-cli/usr/share/doc/arduino-cli/copyright | ||
- cat /Users/sedia/repo/arduino-cli/.licenses/NOTICE.arduino-cli >> debian/arduino-cli/usr/share/doc/arduino-cli/copyright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- cat /Users/sedia/repo/arduino-cli/.licenses/NOTICE.arduino-cli >> debian/arduino-cli/usr/share/doc/arduino-cli/copyright | |
- cat .licenses/NOTICE.arduino-cli >> debian/arduino-cli/usr/share/doc/arduino-cli/copyright |
- name: Build License | ||
run: | | ||
task extract-licenses | ||
task append-license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task append-license |
@@ -4,6 +4,39 @@ includes: | |||
dist: ./DistTasks.yml | |||
|
|||
tasks: | |||
extract-licenses: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this task something like update-deb-copyright
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information